activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dej...@apache.org
Subject svn commit: r923706 - in /activemq/trunk/activemq-core: pom.xml src/main/java/org/apache/activemq/transaction/LocalTransaction.java
Date Tue, 16 Mar 2010 12:21:15 GMT
Author: dejanb
Date: Tue Mar 16 12:21:14 2010
New Revision: 923706

URL: http://svn.apache.org/viewvc?rev=923706&view=rev
Log:
https://issues.apache.org/activemq/browse/AMQ-2594 - including the test and adding some comments

Modified:
    activemq/trunk/activemq-core/pom.xml
    activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transaction/LocalTransaction.java

Modified: activemq/trunk/activemq-core/pom.xml
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/pom.xml?rev=923706&r1=923705&r2=923706&view=diff
==============================================================================
--- activemq/trunk/activemq-core/pom.xml (original)
+++ activemq/trunk/activemq-core/pom.xml Tue Mar 16 12:21:14 2010
@@ -512,8 +512,6 @@
              
              <!-- used just to test potential memory leaks manually -->
              <exclude>**/JDBCTestMemory.*</exclude>
-             <!--  exclude until AMQ-2594 is fixed-->
-             <exclude>**/JDBCNegativeQueueTest.*</exclude>
              
              <exclude>**/amq1490/*</exclude>
              <exclude>**/AMQ1925*</exclude>

Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transaction/LocalTransaction.java
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transaction/LocalTransaction.java?rev=923706&r1=923705&r2=923706&view=diff
==============================================================================
--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transaction/LocalTransaction.java
(original)
+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transaction/LocalTransaction.java
Tue Mar 16 12:21:14 2010
@@ -67,6 +67,8 @@ public class LocalTransaction extends Tr
 
         setState(Transaction.FINISHED_STATE);
         context.getTransactions().remove(xid);
+        // Sync on transaction store to avoid out of order messages in the cursor
+        // https://issues.apache.org/activemq/browse/AMQ-2594
         synchronized (transactionStore) {
             transactionStore.commit(getTransactionId(), false);
 
@@ -92,6 +94,8 @@ public class LocalTransaction extends Tr
         }
         setState(Transaction.FINISHED_STATE);
         context.getTransactions().remove(xid);
+        // Sync on transaction store to avoid out of order messages in the cursor
+        // https://issues.apache.org/activemq/browse/AMQ-2594
         synchronized (transactionStore) {
            transactionStore.rollback(getTransactionId());
 



Mime
View raw message