Return-Path: Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: (qmail 3117 invoked from network); 9 Feb 2010 17:20:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Feb 2010 17:20:12 -0000 Received: (qmail 60189 invoked by uid 500); 9 Feb 2010 17:20:12 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 60139 invoked by uid 500); 9 Feb 2010 17:20:12 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 60130 invoked by uid 99); 9 Feb 2010 17:20:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Feb 2010 17:20:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Feb 2010 17:20:10 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 8E8CB2388897; Tue, 9 Feb 2010 17:19:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r908121 - /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java Date: Tue, 09 Feb 2010 17:19:49 -0000 To: commits@activemq.apache.org From: gtully@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100209171949.8E8CB2388897@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: gtully Date: Tue Feb 9 17:19:49 2010 New Revision: 908121 URL: http://svn.apache.org/viewvc?rev=908121&view=rev Log: browser snapshot of paged in messages is only guaranteed to be > pageSize, test should assert that only Modified: activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java Modified: activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java?rev=908121&r1=908120&r2=908121&view=diff ============================================================================== --- activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java (original) +++ activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JmsQueueBrowserTest.java Tue Feb 9 17:19:49 2010 @@ -29,6 +29,7 @@ import javax.jms.TextMessage; import org.apache.activemq.broker.StubConnection; +import org.apache.activemq.broker.region.BaseDestination; import org.apache.activemq.command.ActiveMQDestination; import org.apache.activemq.command.ActiveMQQueue; import org.apache.activemq.command.ConnectionInfo; @@ -177,7 +178,11 @@ assertNotNull("m2 is null for index: " + i, m2); assertEquals(m1.getJMSMessageID(), m2.getJMSMessageID()); } - assertEquals("got all: ", numMessages, i); + + // currently browse max page size is ignored for a queue browser consumer + // only guarantee is a page size - but a snapshot of pagedinpending is + // used so it is most likely more + assertTrue("got at least our expected minimum in the browser: ", i > BaseDestination.MAX_PAGE_SIZE); assertFalse("nothing left in the browser", browserView.hasMoreElements()); assertNull("consumer finished", consumer.receiveNoWait());