Return-Path: Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: (qmail 11983 invoked from network); 15 Oct 2009 23:52:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Oct 2009 23:52:31 -0000 Received: (qmail 56217 invoked by uid 500); 15 Oct 2009 23:52:31 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 56161 invoked by uid 500); 15 Oct 2009 23:52:30 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 56152 invoked by uid 99); 15 Oct 2009 23:52:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2009 23:52:30 +0000 X-ASF-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2009 23:52:28 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 4AFD72388896; Thu, 15 Oct 2009 23:52:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r825705 - /activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/TransactionContext.cs Date: Thu, 15 Oct 2009 23:52:08 -0000 To: commits@activemq.apache.org From: tabish@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091015235208.4AFD72388896@eris.apache.org> Author: tabish Date: Thu Oct 15 23:52:07 2009 New Revision: 825705 URL: http://svn.apache.org/viewvc?rev=825705&view=rev Log: https://issues.apache.org/activemq/browse/AMQNET-194 TransactionContext was sending commit and rollback commands as async which means no repsonse from the broker. This is bad for multiple reasons one of which is that the ConnectionStateTracker wasn't removing the committed transaction data nor was it cleaning out the request map. Modified: activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/TransactionContext.cs Modified: activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/TransactionContext.cs URL: http://svn.apache.org/viewvc/activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/TransactionContext.cs?rev=825705&r1=825704&r2=825705&view=diff ============================================================================== --- activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/TransactionContext.cs (original) +++ activemq/activemq-dotnet/Apache.NMS.ActiveMQ/trunk/src/main/csharp/TransactionContext.cs Thu Oct 15 23:52:07 2009 @@ -80,7 +80,7 @@ info.Type = (int) TransactionType.Rollback; info.ResponseRequired = false; transactionId = null; - session.Connection.Oneway(info); + session.Connection.SyncRequest(info); } foreach (ISynchronization synchronization in synchronizations) @@ -105,7 +105,7 @@ info.Type = (int) TransactionType.CommitOnePhase; info.ResponseRequired = false; transactionId = null; - session.Connection.Oneway(info); + session.Connection.SyncRequest(info); } foreach (ISynchronization synchronization in synchronizations)