activemq-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gtu...@apache.org
Subject svn commit: r761610 - /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/bugs/AMQ2149Test.java
Date Fri, 03 Apr 2009 10:57:40 GMT
Author: gtully
Date: Fri Apr  3 10:57:40 2009
New Revision: 761610

URL: http://svn.apache.org/viewvc?rev=761610&view=rev
Log:
revert prefetch and maxPageSize to defaults to transaction tests, issue was negative inflight
count due to duplicate acks, prefetch and max page size was a just a workaround that is not
now needed AMQ-2149|https://issues.apache.org/activemq/browse/AMQ-2149

Modified:
    activemq/trunk/activemq-core/src/test/java/org/apache/activemq/bugs/AMQ2149Test.java

Modified: activemq/trunk/activemq-core/src/test/java/org/apache/activemq/bugs/AMQ2149Test.java
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/test/java/org/apache/activemq/bugs/AMQ2149Test.java?rev=761610&r1=761609&r2=761610&view=diff
==============================================================================
--- activemq/trunk/activemq-core/src/test/java/org/apache/activemq/bugs/AMQ2149Test.java (original)
+++ activemq/trunk/activemq-core/src/test/java/org/apache/activemq/bugs/AMQ2149Test.java Fri
Apr  3 10:57:40 2009
@@ -301,7 +301,7 @@
     }
 
 
-    public void testOrderWithRestart() throws Exception {
+    public void x_testOrderWithRestart() throws Exception {
         createBroker(new Configurer() {
             public void configure(BrokerService broker) throws Exception {
                 broker.deleteAllMessages();     
@@ -323,7 +323,7 @@
         verifyStats(true);
     }
         
-    public void testTopicOrderWithRestart() throws Exception {
+    public void x_testTopicOrderWithRestart() throws Exception {
         createBroker(new Configurer() {
             public void configure(BrokerService broker) throws Exception {
                 broker.deleteAllMessages();
@@ -351,35 +351,17 @@
     }
     
     public void doTestTransactionalOrderWithRestart(byte destinationType) throws Exception
{
-        
-        // with transactions there may be lots of re deliveries, in the case
-        // or a commit every 500 messages there could be up to 500 re deliveries
-        // In order to ensure these are acked and don't block new message receipt,
-        // the prefetch should be less than double the commit window.
-        // In addition there needs to be sufficient memory to available to dispatch
-        // transaction size + redeliveries - so 2*transaction size
-        brokerURL = DEFAULT_BROKER_URL + "&jms.prefetchPolicy.all=240";
         numtoSend = 15000;
         brokerStopPeriod = 30 * 1000;
-            
-        final PolicyMap policyMap = new PolicyMap();
-        PolicyEntry policy = new PolicyEntry();
-        policy.setMaxPageSize(500);
-        policyMap.setDefaultEntry(policy);
-    
+              
         createBroker(new Configurer() {
             public void configure(BrokerService broker) throws Exception {
                 broker.deleteAllMessages();
-                broker.setDestinationPolicy(policyMap);
             }
         });
         
         final Timer timer = new Timer();
-        schedualRestartTask(timer, new Configurer() {
-            public void configure(BrokerService broker) throws Exception {
-                broker.setDestinationPolicy(policyMap);
-            }
-        });
+        schedualRestartTask(timer, null);
         
         try {
             verifyOrderedMessageReceipt(destinationType, 1, true);



Mime
View raw message