Return-Path: Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: (qmail 80605 invoked from network); 18 Apr 2008 19:12:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Apr 2008 19:12:32 -0000 Received: (qmail 33076 invoked by uid 500); 18 Apr 2008 19:12:34 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 33057 invoked by uid 500); 18 Apr 2008 19:12:34 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 33048 invoked by uid 99); 18 Apr 2008 19:12:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Apr 2008 12:12:33 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Apr 2008 19:11:58 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id CD2E11A9832; Fri, 18 Apr 2008 12:12:11 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r649658 - /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java Date: Fri, 18 Apr 2008 19:12:11 -0000 To: commits@activemq.apache.org From: chirino@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080418191211.CD2E11A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: chirino Date: Fri Apr 18 12:12:07 2008 New Revision: 649658 URL: http://svn.apache.org/viewvc?rev=649658&view=rev Log: Bad logic was not propagating the transport exception up. Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java?rev=649658&r1=649657&r2=649658&view=diff ============================================================================== --- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java (original) +++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/InactivityMonitor.java Fri Apr 18 12:12:07 2008 @@ -239,9 +239,9 @@ } public void onException(IOException error) { - if (!failed.compareAndSet(false,true)) { - stopMonitorThreads(); - transportListener.onException(error); + if (failed.compareAndSet(false, true)) { + stopMonitorThreads(); + transportListener.onException(error); } }