Return-Path: Delivered-To: apmail-activemq-commits-archive@www.apache.org Received: (qmail 24534 invoked from network); 15 Apr 2008 13:40:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Apr 2008 13:40:47 -0000 Received: (qmail 90388 invoked by uid 500); 15 Apr 2008 13:40:48 -0000 Delivered-To: apmail-activemq-commits-archive@activemq.apache.org Received: (qmail 90369 invoked by uid 500); 15 Apr 2008 13:40:48 -0000 Mailing-List: contact commits-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@activemq.apache.org Delivered-To: mailing list commits@activemq.apache.org Received: (qmail 90359 invoked by uid 99); 15 Apr 2008 13:40:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2008 06:40:48 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Apr 2008 13:40:13 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 8C8431A9832; Tue, 15 Apr 2008 06:40:22 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r648250 - in /activemq/trunk/activemq-core/src/main/java/org/apache/activemq: ActiveMQConnection.java broker/util/CommandAgent.java Date: Tue, 15 Apr 2008 13:40:21 -0000 To: commits@activemq.apache.org From: chirino@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080415134022.8C8431A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: chirino Date: Tue Apr 15 06:40:10 2008 New Revision: 648250 URL: http://svn.apache.org/viewvc?rev=648250&view=rev Log: Avoid the ugly 'Async exception with no exception listener' message from showing up in the output when shutting down the broker. Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQConnection.java activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/util/CommandAgent.java Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQConnection.java URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQConnection.java?rev=648250&r1=648249&r2=648250&view=diff ============================================================================== --- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQConnection.java (original) +++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQConnection.java Tue Apr 15 06:40:10 2008 @@ -1692,7 +1692,7 @@ }); } else { - LOG.warn("Async exception with no exception listener: " + error, error); + LOG.debug("Async exception with no exception listener: " + error, error); } } } Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/util/CommandAgent.java URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/util/CommandAgent.java?rev=648250&r1=648249&r2=648250&view=diff ============================================================================== --- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/util/CommandAgent.java (original) +++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/util/CommandAgent.java Tue Apr 15 06:40:10 2008 @@ -19,6 +19,7 @@ import javax.jms.Connection; import javax.jms.ConnectionFactory; import javax.jms.Destination; +import javax.jms.ExceptionListener; import javax.jms.JMSException; import javax.jms.MessageConsumer; import javax.jms.Session; @@ -39,7 +40,7 @@ * @version $Revision$ * @org.apache.xbean.XBean */ -public class CommandAgent implements Service, InitializingBean, DisposableBean, FactoryBean { +public class CommandAgent implements Service, InitializingBean, DisposableBean, FactoryBean, ExceptionListener { private static final Log LOG = LogFactory.getLog(CommandAgent.class); private String brokerUrl = "vm://localhost"; @@ -137,6 +138,7 @@ public Connection getConnection() throws JMSException { if (connection == null) { connection = createConnection(); + connection.setExceptionListener(this); connection.start(); } return connection; @@ -163,5 +165,12 @@ protected Destination createCommandDestination() { return AdvisorySupport.getAgentDestination(); + } + + public void onException(JMSException exception) { + try { + stop(); + } catch (Exception e) { + } } }