activemq-commits mailing list archives

Author: jstrachan
Date: Tue Dec 13 08:19:06 2005
New Revision: 356520

URL: http://svn.apache.org/viewcvs?rev=356520&view=rev
Log:
fixed bug where setting the clientID on the MBean ObjectName could break a JMX name

Modified:
    incubator/activemq/trunk/activemq-core/src/main/java/org/activemq/broker/jmx/ManagedTransportConnection.java

Modified: incubator/activemq/trunk/activemq-core/src/main/java/org/activemq/broker/jmx/ManagedTransportConnection.java
URL: http://svn.apache.org/viewcvs/incubator/activemq/trunk/activemq-core/src/main/java/org/activemq/broker/jmx/ManagedTransportConnection.java?rev=356520&r1=356519&r2=356520&view=diff
==============================================================================
--- incubator/activemq/trunk/activemq-core/src/main/java/org/activemq/broker/jmx/ManagedTransportConnection.java
(original)
+++ incubator/activemq/trunk/activemq-core/src/main/java/org/activemq/broker/jmx/ManagedTransportConnection.java
Tue Dec 13 08:19:06 2005
@@ -115,7 +115,9 @@
         // Build the object name for the destination
         Hashtable map = new Hashtable(connectorName.getKeyPropertyList());
         map.put("Type", "Connection");
-        map.put("Connection", connectionId);
+        // lets avoid any JMX sensitive characters
+        String jmxConnectionId = connectionId.replace(':', '_');
+        map.put("Connection", jmxConnectionId);
         try {
             return new ObjectName(connectorName.getDomain(), map);
         }