Mailing-List: contact users-help@ace.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@ace.apache.org
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
MIME-Version: 1.0
Date: Tue, 11 Mar 2014 20:32:24 +0100
Message-ID: 
 <CAKvr0DrONLytF8YpSrwTFvYL3v0Yspjdpx81PJmoihZiK1a+Cg@mail.gmail.com>
Subject: Move CollectionCommands to org.apache.ace.gogo ?
From: Bram Pouwelse <bram@pouwelse.com>
To: users@ace.apache.org
Content-Type: multipart/mixed; boundary=001a1134f2be99f38504f459c7ab

--001a1134f2be99f38504f459c7ab
Content-Type: multipart/alternative; boundary=001a1134f2be99f37f04f459c7a9

--001a1134f2be99f37f04f459c7a9
Content-Type: text/plain; charset=ISO-8859-1

Hi,

I've created an Ace client to use from my ci environment, as the client
exits after each script I don't need the web client and jetty for this. But
after removing those I'd loose the "coll" commands the gogo shell.

Is there a reason that the ColllectionCommands is included in
org.apache.ace.rest instead of org.apache.ace.gogo?

I've tried to move the CollectionCommands and didn't see any issues in
that, I've attached the patch in case you think this is a good move.

Thanks!

Bram

--001a1134f2be99f37f04f459c7a9
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,=A0<div><br></div><div>I&#39;ve created an Ace client t=
o use from my ci environment, as the client exits after each script I don&#=
39;t need the web client and jetty for this. But after removing those I&#39=
;d loose the &quot;coll&quot; commands the gogo shell.=A0</div>
<div><br></div><div>Is there a reason that the ColllectionCommands is inclu=
ded in org.apache.ace.rest instead of=A0org.apache.ace.gogo?=A0</div><div><=
br></div><div>I&#39;ve tried to move the CollectionCommands and didn&#39;t =
see any issues in that, I&#39;ve attached the patch in case you think this =
is a good move.=A0</div>
<div><br></div><div>Thanks!</div><div><br></div><div>Bram</div></div>

--001a1134f2be99f37f04f459c7a9--

--001a1134f2be99f38504f459c7ab
Content-Type: text/plain; charset=US-ASCII; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_hsnkshnp0

SW5kZXg6IG9yZy5hcGFjaGUuYWNlLmNsaWVudC5yZXN0L3NyYy9vcmcvYXBhY2hlL2FjZS9jbGll
bnQvcmVzdC9BY3RpdmF0b3IuamF2YQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBvcmcuYXBhY2hlLmFjZS5jbGll
bnQucmVzdC9zcmMvb3JnL2FwYWNoZS9hY2UvY2xpZW50L3Jlc3QvQWN0aXZhdG9yLmphdmEJKHJl
dmlzaW9uIDE1NzYzMDUpCisrKyBvcmcuYXBhY2hlLmFjZS5jbGllbnQucmVzdC9zcmMvb3JnL2Fw
YWNoZS9hY2UvY2xpZW50L3Jlc3QvQWN0aXZhdG9yLmphdmEJKHdvcmtpbmcgY29weSkKQEAgLTE4
LDE0ICsxOCwxMSBAQAogICovCiBwYWNrYWdlIG9yZy5hcGFjaGUuYWNlLmNsaWVudC5yZXN0Owog
Ci1pbXBvcnQgamF2YS51dGlsLlByb3BlcnRpZXM7Ci0KIGltcG9ydCBqYXZheC5zZXJ2bGV0LlNl
cnZsZXQ7CiAKIGltcG9ydCBvcmcuYXBhY2hlLmFjZS5jbGllbnQud29ya3NwYWNlLldvcmtzcGFj
ZU1hbmFnZXI7CiBpbXBvcnQgb3JnLmFwYWNoZS5mZWxpeC5kbS5EZXBlbmRlbmN5QWN0aXZhdG9y
QmFzZTsKIGltcG9ydCBvcmcuYXBhY2hlLmZlbGl4LmRtLkRlcGVuZGVuY3lNYW5hZ2VyOwotaW1w
b3J0IG9yZy5hcGFjaGUuZmVsaXguc2VydmljZS5jb21tYW5kLkNvbW1hbmRQcm9jZXNzb3I7CiBp
bXBvcnQgb3JnLm9zZ2kuZnJhbWV3b3JrLkJ1bmRsZUNvbnRleHQ7CiBpbXBvcnQgb3JnLm9zZ2ku
c2VydmljZS5sb2cuTG9nU2VydmljZTsKIApAQCAtNTAsMTQgKzQ3LDYgQEAKICAgICAgICAgICAg
ICAgICAuc2V0UmVxdWlyZWQoZmFsc2UpCiAgICAgICAgICAgICApCiAgICAgICAgICk7Ci0KLSAg
ICAgICAgUHJvcGVydGllcyBsaXN0UHJvcHMgPSBuZXcgUHJvcGVydGllcygpOwotICAgICAgICBs
aXN0UHJvcHMucHV0KENvbW1hbmRQcm9jZXNzb3IuQ09NTUFORF9TQ09QRSwgImNvbGwiKTsKLSAg
ICAgICAgbGlzdFByb3BzLnB1dChDb21tYW5kUHJvY2Vzc29yLkNPTU1BTkRfRlVOQ1RJT04sIG5l
dyBTdHJpbmdbXSB7ICJmaXJzdCIsICJyZXN0IiB9KTsKLSAgICAgICAgbWFuYWdlci5hZGQoY3Jl
YXRlQ29tcG9uZW50KCkKLSAgICAgICAgICAgIC5zZXRJbnRlcmZhY2UoT2JqZWN0LmNsYXNzLmdl
dE5hbWUoKSwgbGlzdFByb3BzKQotICAgICAgICAgICAgLnNldEltcGxlbWVudGF0aW9uKENvbGxl
Y3Rpb25Db21tYW5kcy5jbGFzcykKLSAgICAgICAgKTsKICAgICB9CiAKICAgICBAT3ZlcnJpZGUK
SW5kZXg6IG9yZy5hcGFjaGUuYWNlLmdvZ28vYm5kLmJuZAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBvcmcuYXBh
Y2hlLmFjZS5nb2dvL2JuZC5ibmQJKHJldmlzaW9uIDE1NzYzMDUpCisrKyBvcmcuYXBhY2hlLmFj
ZS5nb2dvL2JuZC5ibmQJKHdvcmtpbmcgY29weSkKQEAgLTc3LDUgKzc3LDYgQEAKIAlvcmcub3Nn
aS5pbXBsLmJ1bmRsZS5vYnIuKjstc3BsaXQtcGFja2FnZTo9bWVyZ2UtbGFzdCxcCiAJb3JnLnht
bHB1bGwudjE7LXNwbGl0LXBhY2thZ2U6PWZpcnN0LFwKIAlvcmcua3htbDIuaW87LXNwbGl0LXBh
Y2thZ2U6PWZpcnN0LFwKLQlvcmcuYXBhY2hlLmFjZS5nb2dvLmxvZworCW9yZy5hcGFjaGUuYWNl
LmdvZ28ubG9nLFwKKwlvcmcuYXBhY2hlLmFjZS5nb2dvLmNvbGxlY3Rpb24KIAkKXCBObyBuZXds
aW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBvcmcuYXBhY2hlLmFjZS5nb2dvL3NyYy9vcmcvYXBh
Y2hlL2FjZS9nb2dvL0FjdGl2YXRvci5qYXZhCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIG9yZy5hcGFjaGUuYWNl
LmdvZ28vc3JjL29yZy9hcGFjaGUvYWNlL2dvZ28vQWN0aXZhdG9yLmphdmEJKHJldmlzaW9uIDE1
NzYzMDUpCisrKyBvcmcuYXBhY2hlLmFjZS5nb2dvL3NyYy9vcmcvYXBhY2hlL2FjZS9nb2dvL0Fj
dGl2YXRvci5qYXZhCSh3b3JraW5nIGNvcHkpCkBAIC0yMCw2ICsyMCw3IEBACiAKIGltcG9ydCBq
YXZhLnV0aWwuUHJvcGVydGllczsKIAoraW1wb3J0IG9yZy5hcGFjaGUuYWNlLmdvZ28uY29sbGVj
dGlvbi5Db2xsZWN0aW9uQ29tbWFuZHM7CiBpbXBvcnQgb3JnLmFwYWNoZS5hY2UuZ29nby5leGVj
dXRlLkV4ZWN1dGVDb21tYW5kczsKIGltcG9ydCBvcmcuYXBhY2hlLmFjZS5nb2dvLmV4ZWN1dGUu
U2NyaXB0RXhlY3V0b3I7CiBpbXBvcnQgb3JnLmFwYWNoZS5hY2UuZ29nby5sb2cuTG9nQ29tbWFu
ZHM7CkBAIC03Miw2ICs3MywxMSBAQAogICAgICAgICAgICAgICAgIC5zZXRTZXJ2aWNlKExvZ1N0
b3JlLmNsYXNzKQogICAgICAgICAgICAgICAgIC5zZXRSZXF1aXJlZCh0cnVlKSkpOwogCisgICAg
ICAgIG1hbmFnZXIuYWRkKGNyZWF0ZUNvbXBvbmVudCgpCisgICAgICAgICAgICAuc2V0SW50ZXJm
YWNlKE9iamVjdC5jbGFzcy5nZXROYW1lKCksIGNyZWF0ZVByb3BzKENvbGxlY3Rpb25Db21tYW5k
cy5TQ09QRSwgQ29sbGVjdGlvbkNvbW1hbmRzLkZVTkNUSU9OUykpCisgICAgICAgICAgICAuc2V0
SW1wbGVtZW50YXRpb24oQ29sbGVjdGlvbkNvbW1hbmRzLmNsYXNzKQorICAgICAgICApOworICAg
ICAgICAKICAgICAgICAgU3RyaW5nIHNjcmlwdCA9IFN5c3RlbS5nZXRQcm9wZXJ0eSgiYWNlLmdv
Z28uc2NyaXB0Iik7CiAgICAgICAgIGlmIChzY3JpcHQgIT0gbnVsbCkgewogICAgICAgICAgICAg
bG9uZyBkZWxheSA9IExvbmcuZ2V0TG9uZygiYWNlLmdvZ28uc2NyaXB0LmRlbGF5IiwgMzAwTCk7
Cg==
--001a1134f2be99f38504f459c7ab--