Mailing-List: contact dev-help@ace.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ace.apache.org
Received-SPF: pass (athena.apache.org: domain of marcel.offermans@luminis.eu
 designates 157.55.234.120 as permitted sender)
From: Marcel Offermans <marcel.offermans@luminis.eu>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_087688DE-AD99-47DB-8A1A-897E9F4130CB"
Message-ID: <52B256C4-D0EE-421C-A60C-C29E5EC2CD28@luminis.eu>
MIME-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: Adding Shutdown Hook for Agents??
Date: Thu, 11 Sep 2014 09:17:07 +0200
References: 
 <CADmm+Kewc1EO1px8yS9oNOKLaWGV81v0HBE4_Xot6QLvBTViwQ@mail.gmail.com>
To: ACE-dev Apache ACE developers <dev@ace.apache.org>
In-Reply-To: 
 <CADmm+Kewc1EO1px8yS9oNOKLaWGV81v0HBE4_Xot6QLvBTViwQ@mail.gmail.com>

--Apple-Mail=_087688DE-AD99-47DB-8A1A-897E9F4130CB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="us-ascii"

Hello Niclas,

On 10 Sep 2014, at 10:47 am, Niclas Hedhman <niclas@hedhman.org> wrote:

> A long time ago I was a mentor of this project, and now I am actually =
using
> it in $dayjob application. What goes around, comes around... ;-)

Welcome back! :)

> The deployment is happening on Linux 'devices' and we need to support =
that
> the ACE Targets are shutdown via Linux SIGINT (Ctrl-C), i.e. we need a =
JVM
> shutdown hook that do framework.stop(). Fairly simple...
>=20
> It seems logical that this functionality is part of ACE itself, and I =
am
> adding this at the moment. There are 3 choices on this, and I would
> appreciate your thoughts;
>  1. The shutdown hook is always present,
>  2. It is enabled via command-line arguments,
>  3. It is enabled via launcher.properties.
>=20
> which route should be taken?

I see no reason why we should not always have it present, so unless =
someone can come up with a good reason not to, I'd say keep it simple =
and always have this enabled.

> I would also like to contribute this back,
>=20
>  a. I have mostly forgotten how to submit patches with SVN, but recall
> that there were often issue with it. Is there a page explaining the =
exact
> details?

Our page explaining how to submit a patch is rather brief:

http://ace.apache.org/get-involved/issue-tracking.html

I'm sure Google will be able to remind you how to create a patch file. =
If you attach that to an issue, we can review and apply it.


>  b. We will also make a Linux daemon shell that starts and stops =
agents,
> and in the stop it will both issue the SIGINT and if the process isn't
> dying 'soon enough', a SIGKILL will be issued to ensure death and
> destruction. Is ACE community interested in making such script part of =
the
> the 'target' ? Or will that forever remain the responsibility of the =
user
> to put together?

I'll speak for myself, I think this would be interesting to provide to =
our users. At the very least it serves as a good example of how to do =
this.

Greetings, Marcel


--Apple-Mail=_087688DE-AD99-47DB-8A1A-897E9F4130CB--