Return-Path: X-Original-To: apmail-incubator-ace-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-ace-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF1187AE0 for ; Sat, 5 Nov 2011 19:37:13 +0000 (UTC) Received: (qmail 43404 invoked by uid 500); 5 Nov 2011 19:37:13 -0000 Delivered-To: apmail-incubator-ace-dev-archive@incubator.apache.org Received: (qmail 43377 invoked by uid 500); 5 Nov 2011 19:37:13 -0000 Mailing-List: contact ace-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ace-dev@incubator.apache.org Delivered-To: mailing list ace-dev@incubator.apache.org Received: (qmail 43369 invoked by uid 99); 5 Nov 2011 19:37:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Nov 2011 19:37:12 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Nov 2011 19:37:11 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 9AB4936D47 for ; Sat, 5 Nov 2011 19:36:51 +0000 (UTC) Date: Sat, 5 Nov 2011 19:36:51 +0000 (UTC) From: "Denis Koelewijn (Updated) (JIRA)" To: ace-dev@incubator.apache.org Message-ID: <1047715858.3608.1320521811635.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <158844704.57182.1320351332418.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (ACE-206) Refactor the Vaadin webui MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACE-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Koelewijn updated ACE-206: -------------------------------- Attachment: ace-206-1.patch First patch for refactoring of ace-webui-vaadin. Global description of changes: New class AddArtifactWindow, extracted from VaadinClient class. new class LoginWindow, extracted from VaadinClient class, it uses a callback for credential verification. Refactored AbstractAddWindow to use callbacks instead of subclasses, renamed it to GenericAddWindow because it is no longer an abstract class. Removed all private subclasses of AbstractAddWindow from VaadinClient, this functionality is now included in anonymous inner classes created on the fly as callbacks for the GenericAddWindow. Created new package ...webui.domain. Moved Named* classes and OBREntry class to this package. Reformatted a number of classes according to the formatting rules I uploaded in ACE-203. > Refactor the Vaadin webui > ------------------------- > > Key: ACE-206 > URL: https://issues.apache.org/jira/browse/ACE-206 > Project: Ace > Issue Type: Task > Components: Web UI > Affects Versions: 0.8.0 > Reporter: Denis Koelewijn > Attachments: ace-206-1.patch > > > The Vaain webui is in need of refactoring. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira