ace-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Offermans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACE-159) Register servlets under objectClass javax.servlet.Servlet instead of javax.servlet.http.HttpServlet
Date Thu, 28 Jul 2011 15:08:10 GMT

    [ https://issues.apache.org/jira/browse/ACE-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072394#comment-13072394
] 

Marcel Offermans commented on ACE-159:
--------------------------------------

My take on this:
Let's make sure that all ACE servlets just propagate their configuration (as most of them
already do) so using a different whiteboard implementation only require us to specify a different
configuration (basically what you suggest as #1).

We could also try to convince whiteboard implementations to be configurable, so you can configure
the name of the property they listen to, and at least make sure the one in ACE can do this.
While we're on the subject, it would be nice if these implementations could be configured
to talk to a specific HttpService if more than one is available as well (there are quite a
few scenarios that come to mind).

Finally, we could also install a ConfigurationPlugin (104.9) which intercepts our configurations
before they reach the servlets and simply replace one property with the other there if a different
whiteboard implementation is used. Although it is a nice example of the amount of thought
that went into the ConfigurationAdmin service, I still prefer we stick with #1 for now as
it is easier and less confusing.

> Register servlets under objectClass javax.servlet.Servlet instead of javax.servlet.http.HttpServlet
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ACE-159
>                 URL: https://issues.apache.org/jira/browse/ACE-159
>             Project: Ace
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Bram de Kruijff
>         Attachments: ACE-159-toServlet.patch
>
>
> ACE registers its servlets whiteboard style under objectClass=javax.servlet.http.HttpServlet.
The custom whiteboard implementation HttpListener bridges them to available Http services.
> 1) I think strictly speaking this is not spec compliant as HttpServlet is not an interface?
> 2) It is unnecessarily specific as HttpService#registerServlet accepts javax.servlet.Servlet
> 3) It is not (out of the box) portable to Felix HTTP whiteboard or Amdatu Dispatcher
> For these reasons I'd suggest switching to objectClass=javax.servlet.Servlet. Would be
happy to work on a small patch if there is some consensus that this is a good idea.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message