ace-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geert Schuring (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ACE-129) Use artifactId naming convention as used in Felix
Date Fri, 25 Feb 2011 08:51:38 GMT

    [ https://issues.apache.org/jira/browse/ACE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999267#comment-12999267
] 

Geert Schuring commented on ACE-129:
------------------------------------

... and yes, that means the Felix project is using its own plugin incorrectly if you ask me.
For instance, the site mentioned in my previous comment on this issue contains the following
example:

<project>
  <modelVersion>4.0.0</modelVersion>
  <groupId>org.apache.felix</groupId>
  <artifactId>org.apache.felix.log</artifactId>
  <packaging>bundle</packaging>
  <name>Apache Felix Log Service</name>
  <version>0.8.0-SNAPSHOT</version>
  <build>
    <plugins>
      <plugin>
        <groupId>org.apache.felix</groupId>
        <artifactId>maven-bundle-plugin</artifactId>
        <extensions>true</extensions>
        <configuration>
          <instructions>
            <Export-Package>org.osgi.service.log</Export-Package>
            <Private-Package>org.apache.felix.log.impl</Private-Package>
            <Bundle-SymbolicName>${pom.artifactId}</Bundle-SymbolicName>
            <Bundle-Activator>${pom.artifactId}.impl.Activator</Bundle-Activator>
            <Export-Service>org.osgi.service.log.LogService,org.osgi.service.log.LogReaderService</Export-Service>
          </instructions>
        </configuration>
      </plugin>
    </plugins>
  </build>
</project>

This may seem like a good solution, but the fact of the matter is that the following example
would have the exact same result without breaking maven conventions.

<project>
  <modelVersion>4.0.0</modelVersion>
  <groupId>org.apache.felix</groupId>
  <artifactId>felix.log</artifactId>
  <packaging>bundle</packaging>
  <name>Apache Felix Log Service</name>
  <version>0.8.0-SNAPSHOT</version>
  <build>
    <plugins>
      <plugin>
        <groupId>org.apache.felix</groupId>
        <artifactId>maven-bundle-plugin</artifactId>
        <extensions>true</extensions>
        <configuration>
          <instructions>
            <Export-Package>org.osgi.service.log</Export-Package>
            <Private-Package>org.apache.felix.log.impl</Private-Package>
            <Bundle-Activator>org.apache.felix.log.impl.Activator</Bundle-Activator>
            <Export-Service>org.osgi.service.log.LogService,org.osgi.service.log.LogReaderService</Export-Service>
          </instructions>
        </configuration>
      </plugin>
    </plugins>
  </build>
</project>


The maven bundle plugin will combine the groupId and artifactId into "org.apache.felix.log"
as described on http://felix.apache.org/site/apache-felix-maven-bundle-plugin-bnd.html

> Use artifactId naming convention as used in Felix
> -------------------------------------------------
>
>                 Key: ACE-129
>                 URL: https://issues.apache.org/jira/browse/ACE-129
>             Project: Ace
>          Issue Type: Improvement
>    Affects Versions: 0.8.0
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>             Fix For: 0.8.0
>
>
> To be compliant with most OSGi projects, including Apache Felix, the artifactId of our
bundles should look like:
> groupId: org.apache.ace
> artifactId: org.apache.ace.client.automation
> Like this, we will be able to directly use the artifactId in the Bundle-SymbolicName
of the Felix maven-bundle-plugin.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message