ace-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Offermans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACE-483) Daemon Script + Managed Shutdown of Targets
Date Thu, 02 Oct 2014 16:50:33 GMT

    [ https://issues.apache.org/jira/browse/ACE-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156740#comment-14156740
] 

Marcel Offermans commented on ACE-483:
--------------------------------------

I modified the patch a bit:
I left out the generics changes for Java 8/9 because we currently build for Java 7 and I feel
we need to fix that in the whole project, and as a separate "patch".
Changed the shutdown hook to explicitly wait for the framework to shut down. Not doing that
made the JVM shutdown way before bundles were actually stopped. It will wait forever: if the
framework hangs we depend on the script "killing the JVM after a while".
Some typographical changes to the script.
I like the way you split up the target into a "run-develop" and "run-target". I am even thinking
about not providing the "run-develop" option in our binary distribution anymore, but I'd like
to get some community feedback about that.

> Daemon Script + Managed Shutdown of Targets
> -------------------------------------------
>
>                 Key: ACE-483
>                 URL: https://issues.apache.org/jira/browse/ACE-483
>             Project: ACE
>          Issue Type: Improvement
>          Components: Launcher
>            Reporter: Niclas Hedhman
>            Assignee: Marcel Offermans
>         Attachments: ace-1.patch
>
>
> I am submitting a patch for 
>   a. The Tomcat start/stop script for daemon execution of the ACE Management Agent.
>   b. Rename of the run-target/ project to run-develop/ and let the target.jar be moved
to develop/debug-target.jar in the distribution.
>   c. run-target/ now contains the script in a) and an ace.policy file which defaults
to AllPermission, for people to use via the -security argument. It ends up with a target/bin
and target/conf directory in the dist zip.
>   d. Changes to some code that doesn't comply with stricter Java Generics compiler in
Java8/Java9.  One can't have Properties sent to a method that takes Dictionary<String,?>.
Not exhaustive change across all modules.
>   e. Refactored some code to get rid of some Warnings from the build output. Such as
the OptionBuilder.
>   f. Bouncing of baselines that BndTools is shouting about.
> I am not particularly familiar with BndTools, and uncertain how the run-target should
be set up. Perhaps it shouldn't exist at all, and that the script+conf should sit in the launcher
sub-project instead. Assistance is greatly appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message