Return-Path: X-Original-To: apmail-ace-commits-archive@www.apache.org Delivered-To: apmail-ace-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A644102E3 for ; Tue, 6 Aug 2013 13:41:49 +0000 (UTC) Received: (qmail 35271 invoked by uid 500); 6 Aug 2013 13:41:49 -0000 Delivered-To: apmail-ace-commits-archive@ace.apache.org Received: (qmail 35250 invoked by uid 500); 6 Aug 2013 13:41:48 -0000 Mailing-List: contact commits-help@ace.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ace.apache.org Delivered-To: mailing list commits@ace.apache.org Received: (qmail 34943 invoked by uid 99); 6 Aug 2013 13:41:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Aug 2013 13:41:48 +0000 Date: Tue, 6 Aug 2013 13:41:48 +0000 (UTC) From: "Marcel Offermans (JIRA)" To: commits@ace.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACE-404) Error in Comparator for sorting artifact recognizer: services are not really sorted depending on their SERVICE_RANKING MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACE-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730772#comment-13730772 ] Marcel Offermans commented on ACE-404: -------------------------------------- That indeed looks like a bug. Furthermore, I'm not sure if we still need to provide our own comparator for service references. They should be sortable (by rank) by default now. > Error in Comparator for sorting artifact recognizer: services are not really sorted depending on their SERVICE_RANKING > ---------------------------------------------------------------------------------------------------------------------- > > Key: ACE-404 > URL: https://issues.apache.org/jira/browse/ACE-404 > Project: ACE > Issue Type: Bug > Components: Client Repository > Affects Versions: 1.0.0 > Reporter: Wilfried Sibla > > ArtifactRepositoryImpl.SERVICE_RANK_COMPARATOR, line 542 > is: rank1 = (rankObject2 == null) ? 0 : ((Integer) rankObject2).intValue(); > must be: rank2 = (rankObject2 == null) ? 0 : ((Integer) rankObject2).intValue(); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira