ace-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Offermans (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACE-404) Error in Comparator for sorting artifact recognizer: services are not really sorted depending on their SERVICE_RANKING
Date Wed, 07 Aug 2013 17:18:48 GMT

    [ https://issues.apache.org/jira/browse/ACE-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732179#comment-13732179
] 

Marcel Offermans commented on ACE-404:
--------------------------------------

What I meant is that ServiceReference now implements Comparable, so we can simply sort them
by their natural order. That means we can delete our own comparator. Less code, less bugs.
:)
                
> Error in Comparator for sorting artifact recognizer: services are not really sorted depending
on their SERVICE_RANKING
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: ACE-404
>                 URL: https://issues.apache.org/jira/browse/ACE-404
>             Project: ACE
>          Issue Type: Bug
>          Components: Client Repository
>    Affects Versions: 1.0.0
>            Reporter: Wilfried Sibla
>
> ArtifactRepositoryImpl.SERVICE_RANK_COMPARATOR, line 542
> is: rank1 = (rankObject2 == null) ? 0 : ((Integer) rankObject2).intValue();
> must be: rank2 = (rankObject2 == null) ? 0 : ((Integer) rankObject2).intValue();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message