ace-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bram de Kruijff (JIRA)" <>
Subject [jira] [Commented] (ACE-382) Implement a FeedbackControl service.
Date Thu, 22 Aug 2013 08:49:52 GMT


Bram de Kruijff commented on ACE-382:

Under ACE-347 we have added FeedBackHandler as a control delegate and the FeedbackChannel
interface (see below) This allows a custom controller to lookup and write to channels as well
as deciding to send the feedback to the server. 

In addition I propose;

* What channels are available is a configuration aspect that must match channels on the servers
* What the local log maximum size is before truncating is a configuration aspect (see ACE-381)
* DefaultController will simply send feedback every sync iteration for all available channels

Does this cover the "control all aspects" as mentioned in the description of this issue?

public interface FeedbackHandler {

    /** Returns the feedback channels names */
    List<String> getChannelNames();

    /** Returns the feedback channel for a name */
    FeedbackChannel getChannel(String name);

public interface FeedbackChannel {

    /** Synchronizes the feedback with the current server. Ensures the server has at least
as much feedback data as we do. */
    void sendFeedback() throws RetryAfterException, IOException;

    /** Logs a new message to the channel.*/
    void write(int type, Map<String, String> properties) throws IOException;

> Implement a FeedbackControl service.
> ------------------------------------
>                 Key: ACE-382
>                 URL:
>             Project: ACE
>          Issue Type: Task
>          Components: Log, Management Agent
>            Reporter: Marcel Offermans
> On the target, the management should expose a FeedbackControl service API that allows
consumers to control every aspect of the feedback mechanism.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message