Return-Path: X-Original-To: apmail-ace-commits-archive@www.apache.org Delivered-To: apmail-ace-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44BD3DC21 for ; Tue, 14 Aug 2012 08:49:39 +0000 (UTC) Received: (qmail 75717 invoked by uid 500); 14 Aug 2012 08:49:39 -0000 Delivered-To: apmail-ace-commits-archive@ace.apache.org Received: (qmail 75634 invoked by uid 500); 14 Aug 2012 08:49:38 -0000 Mailing-List: contact commits-help@ace.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ace.apache.org Delivered-To: mailing list commits@ace.apache.org Received: (qmail 75593 invoked by uid 99); 14 Aug 2012 08:49:38 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Aug 2012 08:49:38 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1BB782C5AD0 for ; Tue, 14 Aug 2012 08:49:38 +0000 (UTC) Date: Tue, 14 Aug 2012 19:49:38 +1100 (NCT) From: "J.W. Janssen (JIRA)" To: commits@ace.apache.org Message-ID: <1890064001.6773.1344934178114.JavaMail.jiratomcat@arcas> In-Reply-To: <639051353.36333.1332252337792.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Closed] (ACE-234) Approve button does not react to the right signals MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACE-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] J.W. Janssen closed ACE-234. ---------------------------- Assignee: (was: Marcel Offermans) > Approve button does not react to the right signals > -------------------------------------------------- > > Key: ACE-234 > URL: https://issues.apache.org/jira/browse/ACE-234 > Project: ACE > Issue Type: Bug > Reporter: Marcel Offermans > > ACE-227 introduced a nice extension to disable the automatic approval of changes to each target. The approve button implements the wrong logic for determining when to be enabled or disabled. Also, when you press the button to approve the changes, the button should disable, giving you the feedback that your click "worked". -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira