ace-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Offermans (Commented) (JIRA)" <>
Subject [jira] [Commented] (ACE-259) Support for metatype schema v1.1 (and beyond)
Date Fri, 13 Apr 2012 13:01:19 GMT


Marcel Offermans commented on ACE-259:

Definitely, feel free to improve the implementation to:
a) make sure we don't build a full DOM when we only want to check some attributes at the start
of the stream;
b) actually look for the metadata attribute instead of making assumptions.
> Support for metatype schema v1.1 (and beyond)
> ---------------------------------------------
>                 Key: ACE-259
>                 URL:
>             Project: ACE
>          Issue Type: Improvement
>            Reporter: Bram de Kruijff
>            Assignee: Bram de Kruijff
> The configuration helper implementation hardcodes a check for "",
but v1.1 and v.1.2 are also valid schemas. AFAICS there is no regression risk in accepting
v1.1 and 1.2 as long as the provider autoconf rp can handle them. Unfortunatly, there is no
way to express version constraints on this level.
> So..
> 1) Create seperate helpers for v1.1. & v1.2
> 2) Make this helper accept v1.1 & v.1.2
> 3) Rely on org.apache.felix.metatype.MetaDataReader to determine validity
> IMHO option 1 is unnecessarily heavy, option 2 is the easiest fix and option 3 the most
elegant and robust solution. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message