Return-Path: X-Original-To: apmail-accumulo-user-archive@www.apache.org Delivered-To: apmail-accumulo-user-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E15BB100CB for ; Sun, 25 Jan 2015 18:49:41 +0000 (UTC) Received: (qmail 21253 invoked by uid 500); 25 Jan 2015 18:49:37 -0000 Delivered-To: apmail-accumulo-user-archive@accumulo.apache.org Received: (qmail 21201 invoked by uid 500); 25 Jan 2015 18:49:37 -0000 Mailing-List: contact user-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@accumulo.apache.org Delivered-To: mailing list user@accumulo.apache.org Received: (qmail 21192 invoked by uid 99); 25 Jan 2015 18:49:37 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Jan 2015 18:49:37 +0000 Received: from mail-qg0-f50.google.com (mail-qg0-f50.google.com [209.85.192.50]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 7DBCF1A01E4 for ; Sun, 25 Jan 2015 18:49:36 +0000 (UTC) Received: by mail-qg0-f50.google.com with SMTP id f51so4291939qge.9 for ; Sun, 25 Jan 2015 10:49:34 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.10.201 with SMTP id q9mr18769488qaq.48.1422211774732; Sun, 25 Jan 2015 10:49:34 -0800 (PST) Received: by 10.229.89.137 with HTTP; Sun, 25 Jan 2015 10:49:34 -0800 (PST) In-Reply-To: References: Date: Sun, 25 Jan 2015 13:49:34 -0500 Message-ID: Subject: Re: [VOTE] Apache Accumulo 1.6.2 RC2 From: Christopher To: user@accumulo.apache.org Content-Type: multipart/alternative; boundary=001a11c2c15ea0e2f3050d7e7be1 --001a11c2c15ea0e2f3050d7e7be1 Content-Type: text/plain; charset=UTF-8 Another issue: the stated SHA1 does not match. The commit actually appears to be: 03a3d18b9150fe7f42f024bbc0589c61609b5522 It looks like what happened was simply that you pushed the commit to bump to 1.6.3-SNAPSHOT onto the rc2 branch accidentally. -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Sun, Jan 25, 2015 at 1:10 PM, Christopher wrote: > Also, -1 due to the problems Sean identified. > > > -- > Christopher L Tubbs II > http://gravatar.com/ctubbsii > > On Sun, Jan 25, 2015 at 3:19 AM, Sean Busbey wrote: > >> -1 >> >> Corey, I'm really sorry for the churn. I thought I ran both forward and >> backward compatibility modes last time (-old 1.6.1 -new 1.6.2 as well as >> -old 1.6.2 -new 1.6.1), but I must have just eyeballed the output of the >> 1.6.1 -> 1.6.2 report for problems with forward compatibility. >> >> I ran things again this time (as a formality) and the 1.6.2 -> 1.6.1 >> check turned up 2 issues. >> >> 1) minicluster.ServerType added enum members >> >> Specifically TRACER and MONITOR. This changes the public API because >> ServerType is in it, and a client built against 1.6.2 could refer to these >> enum values and then get a NoSuchFieldError if they try to go back to >> 1.6.1. This only shows up as a low severity "other" issue in the 1.6.1 -> >> 1.6.2 check, which is probably why I didn't see it. >> >> 2) core.client.mapreduce.AbstractInputFormat.getConfiguration(JobContext) >> changed from package-private to public >> >> This causes the method to show up as a new part of the public API. This >> issue only shows up in the 1.6.2 -> 1.6.1 check below. >> >> >> Here are the specific report outputs for others to look: >> >> * 1.6.0 -> 1.6.2 (added things are fine, because the change might be from >> 1.6.0 -> 1.6.1) >> >> http://people.apache.org/~busbey/compat_reports/accumulo/1.6.0_to_1.6.2/compat_report.html >> * 1.6.1 -> 1.6.2 (nothing should be added, but it's easier to just pay >> attention to the next one) >> >> http://people.apache.org/~busbey/compat_reports/accumulo/1.6.1_to_1.6.2/compat_report.html >> * 1.6.2 -> 1.6.1 (under a semver patch increment, this should be just as >> strong an assertion as the reverse) >> >> http://people.apache.org/~busbey/compat_reports/accumulo/1.6.2_to_1.6.1/compat_report.html >> >> >> >> On Fri, Jan 23, 2015 at 8:02 PM, Corey Nolet wrote: >> >>> Devs, >>> >>> Please consider the following candidate for Apache Accumulo 1.6.2 >>> >>> Branch: 1.6.2-rc2 >>> SHA1: 34987b4c8b4d896bbf2d26be8e70f70976614c0f >>> Staging Repository: >>> https://repository.apache.org/content/repositories/orgapacheaccumulo-1020/ >>> >>> Source tarball: >>> https://repository.apache.org/content/repositories/orgapacheaccumulo-1020/org/apache/accumulo/accumulo/1.6.2/accumulo-1.6.2-src.tar.gz >>> Binary tarball: >>> https://repository.apache.org/content/repositories/orgapacheaccumulo-1020/org/apache/accumulo/accumulo/1.6.2/accumulo-1.6.2-bin.tar.gz >>> (Append ".sha1", ".md5" or ".asc" to download the signature/hash for >>> a given artifact.) >>> >>> Signing keys available at: https://www.apache.org/dist/accumulo/KEYS >>> >>> Over 1.6.1, we have 140 issues resolved >>> https://git-wip-us.apache.org/repos/asf?p=accumulo.git;a=blob;f=CHANGES;h=26bdc0373cbbc26ef148db46c0a2cd638cb8c2b4;hb=1.6.2-rc2 >>> >>> Testing: All unit, integration and functional tests are passing. >>> >>> The vote will be extended as a result of the weekend and will be >>> open until Tuesday, January 28th 12:00AM UTC (1/27 8:00PM ET, 1/27 5:00PM >>> PT) >>> >> >> >> >> -- >> Sean >> > > --001a11c2c15ea0e2f3050d7e7be1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Another issue: the stated SHA1 does not match. The commit = actually appears to be:=C2=A003a3d18b9150fe7f42f024bbc0589c61609b5522
It= looks like what happened was simply that you pushed the commit to bump to = 1.6.3-SNAPSHOT onto the rc2 branch accidentally.


--
Chris= topher L Tubbs II
http://gravatar.com/ctubbsii

On Sun, Jan 25, 2015 at 1:10 PM, Christopher= <ctubbsii@apache.org> wrote:
Also, -1 due to the problems Sean identified.
<= div class=3D"gmail_extra">

--
Christopher= L Tubbs II
h= ttp://gravatar.com/ctubbsii

On Sun, Jan 25, 2015 at 3:19 AM, Sean Busbey= <busbey@cloudera.com> wrote:
-1=C2=A0

Corey, I'm really so= rry for the churn. I thought I ran both forward and backward compatibility = modes last time (-old 1.6.1 -new 1.6.2 as well as -old 1.6.2 -new 1.6.1), b= ut I must have just eyeballed the output of the 1.6.1 -> 1.6.2 report fo= r problems with forward compatibility.

I ran thing= s again this time (as a formality) and the 1.6.2 -> 1.6.1 check turned u= p 2 issues.

1) minicluster.ServerType added enum m= embers

Specifically TRACER and MONITOR. This chang= es the public API because ServerType is in it, and a client built against 1= .6.2 could refer to these enum values and then get a NoSuchFieldError if th= ey try to go back to 1.6.1. This only shows up as a low severity "othe= r" issue in the 1.6.1 -> 1.6.2 check, which is probably why I didn&= #39;t see it.

2) core.client.mapreduce.AbstractInp= utFormat.getConfiguration(JobContext) changed from package-private to publi= c

This causes the method to show up as a new part = of the public API. This issue only shows up in the 1.6.2 -> 1.6.1 check = below.


Here are the specific report= outputs for others to look:

* 1.6.0 -> 1.6.2 (= added things are fine, because the change might be from 1.6.0 -> 1.6.1)<= /div>
* 1.6.1 -> 1.6.2 (nothing should be added, but it's e= asier to just pay attention to the next one)
* 1.6.2 -> 1= .6.1 (under a semver patch increment, this should be just as strong an asse= rtion as the reverse)



On Fri, Jan 23= , 2015 at 8:02 PM, Corey Nolet <cjnolet@apache.org> wrote:<= br>
=C2=A0 Devs,

=C2=A0 =C2=A0 Please consider the following candida= te for Apache Accumulo 1.6.2

=C2=A0 =C2=A0 Branch:= 1.6.2-rc2
=C2=A0 =C2=A0 SHA1: 34987b4c8b4d896bbf2d26be8e70f70976= 614c0f

<= div>=C2=A0 =C2=A0 Binary tarball: https://repository.apache.= org/content/repositories/orgapacheaccumulo-1020/org/apache/accumulo/accumul= o/1.6.2/accumulo-1.6.2-bin.tar.gz
=C2=A0 =C2=A0 (Append "= ;.sha1", ".md5" or ".asc" to download the signatur= e/hash for a given artifact.)

=C2=A0 =C2=A0 Signin= g keys available at: https://www.apache.org/dist/accumulo/KEYS
<= br>





<= font color=3D"#888888">--
Sean


--001a11c2c15ea0e2f3050d7e7be1--