accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] milleruntime commented on a change in pull request #1411: Move system iterators to iteratorsImpl package. Closes #1390
Date Wed, 06 Nov 2019 19:32:16 GMT
milleruntime commented on a change in pull request #1411: Move system iterators to iteratorsImpl
package. Closes #1390
URL: https://github.com/apache/accumulo/pull/1411#discussion_r343286221
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/iterators/SortedMapIterator.java
 ##########
 @@ -39,7 +40,7 @@
  * columnFamilies passed into seek(). If you want a Map-backed Iterator that returns only
sought
  * CFs, construct a new ColumnFamilySkippingIterator(new SortedMapIterator(map)).
  *
- * @see org.apache.accumulo.core.iterators.system.ColumnFamilySkippingIterator
+ * @see ColumnFamilySkippingIterator
  */
 public class SortedMapIterator implements InterruptibleIterator {
 
 Review comment:
   This appears to be mainly used by tests, with the exception of the InMemoryMap.  I think
we may have to split this into two Iterators, one that is interruptible for internal use and
the other generic SortedMapIterator that implements SKVI for public use, which shouldn't need
to be interrupted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message