accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] keith-turner commented on a change in pull request #1410: check that the WAL directory and log files can sync
Date Wed, 06 Nov 2019 14:27:04 GMT
keith-turner commented on a change in pull request #1410: check that the WAL directory and
log files can sync
URL: https://github.com/apache/accumulo/pull/1410#discussion_r343120357
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
 ##########
 @@ -3002,6 +3009,24 @@ public TServerInstance getTabletSession() {
     }
   }
 
+  private void checkWalCanSync(ServerContext context) {
+    VolumeChooserEnvironment chooserEnv =
+        new VolumeChooserEnvironmentImpl(VolumeChooserEnvironment.ChooserScope.LOGGER, context);
+    String logPath = fs.choose(chooserEnv, ServerConstants.getBaseUris(context)) + Path.SEPARATOR
+        + ServerConstants.WAL_DIR;
+    if (!fs.canSyncAndFlush(new Path(logPath))) {
+      // sleep a few seconds in case this is at cluster start...give monitor
+      // time to start so the warning will be more visible
+      try {
 
 Review comment:
   Could use `UtilWaitThread.sleep()` its an internal Accumulo util

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message