accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] keith-turner commented on a change in pull request #1411: Move system iterators to iteratorsImpl package. Closes #1390
Date Wed, 06 Nov 2019 14:09:14 GMT
keith-turner commented on a change in pull request #1411: Move system iterators to iteratorsImpl
package. Closes #1390
URL: https://github.com/apache/accumulo/pull/1411#discussion_r343113326
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/iteratorsImpl/system/InterruptibleIterator.java
 ##########
 @@ -14,7 +14,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.accumulo.core.iterators.system;
+package org.apache.accumulo.core.iteratorsImpl.system;
 
 Review comment:
   > Wasn't the InterruptibleIterator created as an interface for users? 
   
   This should only be used internally.  Once we get APILyzer running on the iter packages
hopefully it would catch any use.  Also, it seems like any use would show up in the diff for
this patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message