accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1409: Corrected servlet parameter handling so that it does not break things
Date Mon, 04 Nov 2019 15:52:46 GMT
ctubbsii commented on a change in pull request #1409: Corrected servlet parameter handling
so that it does not break things
URL: https://github.com/apache/accumulo/pull/1409#discussion_r342122238
 
 

 ##########
 File path: server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/trace/Basic.java
 ##########
 @@ -51,13 +51,14 @@
 
   public static String getStringParameter(HttpServletRequest req, String name,
       String defaultValue) {
-    String result = req.getParameter(name).replaceAll("[^A-Za-z]", "");
+    final String result = req.getParameter(name);
     if (result == null) {
       return defaultValue;
     }
     return result;
   }
 
+
 
 Review comment:
   This extra whitespace will probably get deleted when the project is built, due to the formatter
plugin. Please run the formatter with `mvn package -DskipTests` and update the PR with any
changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message