accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] milleruntime commented on issue #1400: Move AbstractLexicoder to API
Date Fri, 01 Nov 2019 20:35:32 GMT
milleruntime commented on issue #1400: Move AbstractLexicoder to API
URL: https://github.com/apache/accumulo/pull/1400#issuecomment-548941480
 
 
   > > I had some reservations initially, because there's already two type hierarchies
in the lexicoder package for public API, and I wasn't sure if this would complicate things,
but I now think it's probably fine.
   > 
   > I am leaning towards just removing the class since it is in the impl package and we
don't need both.
   
   After looking into this, I discovered that all the lexicoder tests use this class so I
think moving it is fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message