accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on issue #1386: Update Native Maps to use more recent C++ standards
Date Fri, 01 Nov 2019 00:09:06 GMT
ctubbsii commented on issue #1386: Update Native Maps to use more recent C++ standards 
URL: https://github.com/apache/accumulo/issues/1386#issuecomment-548617075
 
 
   Those are all very good reasons to use cmake. I'm not opposed. I just want to understand
the benefits.
   
   I do wonder if it's a good idea to add third party dependencies to code which is currently
very small, and has very minimal dependencies. Even if it's a performance benefit... or a
maintenance benefit (less code)... it may not be worth the trade off. It'd be nice if that
could be done as an independent task.
   
   As I see it, there are 3 things being discussed (and worked on) here:
   
   1. Change the build system for the native code (make -> cmake and/or improvements to
the hard-coded flags in the Makefile)
   2. Modernize the code (using more recent C++ standards)
   3. Reduce some of our custom code with third party libraries that do the job better
   
   In my opinion, all three of these are possibly good improvements, but they should be decoupled
from one another. We're talking about making all these changes at once, and I think they each
have their own pros and cons, and they should be done completely independently. That will
help facilitate code reviews, and discussions about pros/cons of specific change proposals.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message