accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1381: Update gc metrics reporting to use hadoop metrics2
Date Mon, 07 Oct 2019 23:59:44 GMT
ctubbsii commented on a change in pull request #1381: Update gc metrics reporting to use hadoop
metrics2
URL: https://github.com/apache/accumulo/pull/1381#discussion_r332285056
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -529,8 +529,9 @@
       "When the gc runs it can make a lot of changes to the metadata, on completion, "
           + " to force the changes to be written to disk, the metadata and root tables can
be flushed"
           + " and possibly compacted. Legal values are: compact - which both flushes and
compacts the"
-          + " metadata; flush - which flushes only (compactions may be triggered if required);
or none."
-          + " Since 2.0, the default is flush. Previously the default action was a full compaction."),
+          + " metadata; flush - which flushes only (compactions may be triggered if required);
or none"),
+  GC_METRICS_ENABLED("gc.enable.metrics", "true", PropertyType.BOOLEAN,
 
 Review comment:
   For consistency, with other configs, I suggest:
   
   ```suggestion
     GC_METRICS_ENABLED("gc.metrics.enabled", "true", PropertyType.BOOLEAN,
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message