accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1376: Add gc metrics reporting
Date Thu, 26 Sep 2019 20:29:49 GMT
ctubbsii commented on a change in pull request #1376: Add gc metrics reporting
URL: https://github.com/apache/accumulo/pull/1376#discussion_r328809338
 
 

 ##########
 File path: server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java
 ##########
 @@ -186,6 +191,16 @@ public SimpleGarbageCollector(Opts opts, VolumeManager fs,
 
     final AccumuloConfiguration conf = getConfiguration();
 
+    GcMetrics2 gcMetrics2 = null;
+    MetricsSystemHelper.configure("acc_gc");
+    gcMetrics2 = GcMetrics2.init(this, MetricsSystemHelper.getInstance());
+    gcMetrics2.register();
+
+    // if (conf.getBoolean(Property.GC_ENABLE_METRICS2)) {
+    // MetricsSystemHelper.configure(SimpleGarbageCollector.class.getSimpleName());
+    // GcMetrics2.init(this, MetricsSystemHelper.getInstance());
+    // }
 
 Review comment:
   Should remove deleted code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message