accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts
Date Thu, 05 Sep 2019 21:24:02 GMT
ctubbsii commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts
URL: https://github.com/apache/accumulo/pull/1330#discussion_r321489578
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/cli/ConfigOpts.java
 ##########
 @@ -96,6 +117,19 @@ public synchronized SiteConfiguration getSiteConfiguration() {
   @Override
   public void parseArgs(String programName, String[] args, Object... others) {
     super.parseArgs(programName, args, others);
+    if (legacyOpts != null || legacyOptsBoolean) {
+      var errmsg = new StringBuilder();
+      for (String option : args) {
+        if (LEGACY_OPTION_MSG.keySet().contains(option)) {
+          errmsg.append("Option ").append(option).append(" has been dropped - ")
+              .append(LEGACY_OPTION_MSG.get(option)).append("\n");
+        }
+      }
+      // prints error to console if ran from the command line otherwise there is no way to
know that
+      // an error occurred
+      System.err.println(errmsg.append("See '-o' property override option").toString());
+      throw new IllegalArgumentException(errmsg.toString());
 
 Review comment:
   Forget this comment... you probably do still need it right now... but only because of the
problem I saw in #1349 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message