accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts
Date Thu, 05 Sep 2019 21:22:21 GMT
ctubbsii commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts
URL: https://github.com/apache/accumulo/pull/1330#discussion_r321475501
 
 

 ##########
 File path: server/gc/src/main/java/org/apache/accumulo/gc/SimpleGarbageCollector.java
 ##########
 @@ -258,12 +250,10 @@ public boolean getCandidates(String continuePoint, List<String>
result)
     public void delete(SortedMap<String,String> confirmedDeletes) throws TableNotFoundException
{
       final VolumeManager fs = getContext().getVolumeManager();
 
-      if (opts.safeMode) {
-        if (opts.verbose) {
-          System.out.println("SAFEMODE: There are " + confirmedDeletes.size()
-              + " data file candidates marked for deletion.%n"
-              + "          Examine the log files to identify them.%n");
-        }
+      if (inSafeMode()) {
+        System.out.println("SAFEMODE: There are " + confirmedDeletes.size()
+            + " data file candidates marked for deletion.%n"
 
 Review comment:
   I tested this and this seems to print a literal `%n`. I don't think that works with `println`.
Could switch to `printf` instead, or just use `\n`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message