From notifications-return-52029-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Fri Aug 30 19:58:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4979918065E for ; Fri, 30 Aug 2019 21:58:20 +0200 (CEST) Received: (qmail 56029 invoked by uid 500); 30 Aug 2019 19:58:19 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 56012 invoked by uid 99); 30 Aug 2019 19:58:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Aug 2019 19:58:19 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] [accumulo] ctubbsii commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts Message-ID: <156719509953.15805.17276149242417192986.gitbox@gitbox.apache.org> Date: Fri, 30 Aug 2019 19:58:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ctubbsii commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts URL: https://github.com/apache/accumulo/pull/1330#discussion_r319656288 ########## File path: core/src/main/java/org/apache/accumulo/core/cli/ConfigOpts.java ########## @@ -104,4 +121,14 @@ public void parseArgs(String programName, String[] args, Object... others) { } } } + + /** + * Performs special processing of deprecated options. Could be cleaned up periodically as + * deprecations are deleted + */ + private static void processDeprecation(String option, String value) { + if ("-s".equals(option)) { Review comment: `--address` is definitely going to be its own beast. I wouldn't worry about it here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services