accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1313: fix #936 store root tablet file list in Zookeeper
Date Tue, 13 Aug 2019 21:31:30 GMT
ctubbsii commented on a change in pull request #1313: fix #936 store root tablet file list
in Zookeeper
URL: https://github.com/apache/accumulo/pull/1313#discussion_r313602409
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java
 ##########
 @@ -198,11 +196,11 @@ public Options fetch(ColumnType... colsToFetch) {
     @Override
     public TableRangeOptions forTable(TableId tableId) {
       if (tableId.equals(RootTable.ID)) {
-        this.table = SEED_TABLE;
+        this.level = DataLevel.ROOT;
 
 Review comment:
   This DataLevel concept and this conditional in particular seems eerily similar to a first
pass I made several years ago at something like this: https://github.com/apache/accumulo/blob/757f62b5a1e2abd6d97d803f5325fdae622167eb/core/src/main/java/org/apache/accumulo/core/metadata/MetadataServicer.java#L41-L49
   
   I think it's probably worth reconciling those as a future / follow-on task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message