accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii edited a comment on issue #1312: Backport BulkIngest test. Closes #1288
Date Wed, 07 Aug 2019 14:28:11 GMT
ctubbsii edited a comment on issue #1312: Backport BulkIngest test. Closes #1288
URL: https://github.com/apache/accumulo/pull/1312#issuecomment-519121329
 
 
   > > That repository has a 1.9 branch, specifically for testing the 1.9 code.
   > 
   > That branch has diverged significantly from the accumulo-testing master branch. I
don't think its worth the effort to try to keep it up to date for 1.9 or add new stuff to
it.
   
   Why does it matter that it has diverged from its master? This repo is even more divergent
from the testing master. Why does the difference with the testing/master branch matter? From
my perspective, what matters is that this is entirely new test code to 1.9... and the question
is where do we want to maintain a suite of testing code that isn't part of ITs/UTs. As far
as I can tell, we already made that decision, and it was too maintain it in the separate repo.
More recent work has been done there since that decision than here. So, it doesn't make sense
to me that we'd put this new code here. I'm open to an argument for having it here, I just
don't understand the case made so far.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message