From notifications-return-50997-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Thu Jul 11 18:44:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D2E021804BB for ; Thu, 11 Jul 2019 20:44:19 +0200 (CEST) Received: (qmail 9034 invoked by uid 500); 11 Jul 2019 18:44:19 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 9023 invoked by uid 99); 11 Jul 2019 18:44:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jul 2019 18:44:19 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] [accumulo] keith-turner edited a comment on issue #1210: Create type for time to use when reading and write Accumulo metadata Message-ID: <156287065414.12096.10873747279796003325.gitbox@gitbox.apache.org> Date: Thu, 11 Jul 2019 18:44:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit keith-turner edited a comment on issue #1210: Create type for time to use when reading and write Accumulo metadata URL: https://github.com/apache/accumulo/issues/1210#issuecomment-510606684 Looks good @hkeebler. Few questions * Why can't MetadataTime be immutable? Much easier to reason about immutable types. * Why have the constructor with no TimeType? Thinking its better to always be explicit. * Why have the constructor that does deserialization? Could this possibly be hidden away in private Ample code? Also, you could possibly use Objects.hashCode to implement your hashCode method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services