accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] keith-turner edited a comment on issue #1210: Create type for time to use when reading and write Accumulo metadata
Date Thu, 11 Jul 2019 18:44:14 GMT
keith-turner edited a comment on issue #1210: Create type for time to use when reading and
write Accumulo metadata
URL: https://github.com/apache/accumulo/issues/1210#issuecomment-510606684
 
 
   Looks good @hkeebler.  Few questions
    * Why can't MetadataTime be immutable?  Much easier to reason about immutable types.
    * Why have the constructor with no TimeType? Thinking its better to always be explicit.
    * Why have the constructor that does deserialization?  Could this possibly be hidden away
in private Ample code?
   
   Also, you could possibly use Objects.hashCode to implement your hashCode method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message