accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] keith-turner commented on a change in pull request #1253: Created SequenceLexicoder to resolve #1252
Date Mon, 08 Jul 2019 14:25:24 GMT
keith-turner commented on a change in pull request #1253: Created SequenceLexicoder to resolve
#1252
URL: https://github.com/apache/accumulo/pull/1253#discussion_r301122746
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/lexicoder/ListLexicoder.java
 ##########
 @@ -30,6 +30,8 @@
  * A lexicoder to encode/decode a Java List to/from a byte array where the concatenation
of each
  * encoded element sorts lexicographically.
  *
+ * Note: Empty lists are not supported.
+ *
 
 Review comment:
   This could use the `@see` javadoc tag to point to SequenceLexicoder
   
   Also, could make the encode method throw an exception when encoding an empty list.  The
exception could have a message saying not support and mention the new encoded.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message