accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] keith-turner commented on a change in pull request #1243: Fix #1242 - Update MasterMetadataUtil.getUpdateForTabletDataFile
Date Tue, 02 Jul 2019 20:18:34 GMT
keith-turner commented on a change in pull request #1243: Fix #1242 - Update MasterMetadataUtil.getUpdateForTabletDataFile
URL: https://github.com/apache/accumulo/pull/1243#discussion_r299664340
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/util/MasterMetadataUtil.java
 ##########
 @@ -247,61 +243,58 @@ public static void updateTabletDataFile(ServerContext context, KeyExtent
extent,
       String address, ZooLock zooLock, Set<String> unusedWalLogs, TServerInstance lastLocation,
       long flushId) {
     if (extent.isRootTablet()) {
-      if (unusedWalLogs != null) {
-        updateRootTabletDataFile(context, unusedWalLogs);
-      }
-      return;
+      updateRootTabletDataFile(context, unusedWalLogs);
+    } else {
 
 Review comment:
   I like this restructuring of the code to use if/else dropping the return.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message