From notifications-return-49719-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Fri May 3 14:37:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B757A18064D for ; Fri, 3 May 2019 16:37:46 +0200 (CEST) Received: (qmail 85135 invoked by uid 500); 3 May 2019 14:37:46 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 85114 invoked by uid 99); 3 May 2019 14:37:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2019 14:37:46 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] [accumulo] keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option Message-ID: <155689426103.22062.4036325696783630030.gitbox@gitbox.apache.org> Date: Fri, 03 May 2019 14:37:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option URL: https://github.com/apache/accumulo/pull/1135#discussion_r280799746 ########## File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java ########## @@ -71,10 +71,11 @@ public int execute(final String fullCommand, final CommandLine cl, final Shell s scanner.setTimeout(getTimeout(cl), TimeUnit.MILLISECONDS); setupSampling(tableName, cl, shellState, scanner); + addScanIterators(shellState, cl, scanner, ""); for (int i = 0; i < cl.getArgs().length; i++) { setUpIterator(Integer.MAX_VALUE - cl.getArgs().length + i, "grep" + i, cl.getArgs()[i], - scanner, cl, negate); + scanner, cl, negate, shellState); Review comment: `shellState` is newly passed, but it seems like its not used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services