accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1148: Quick query
Date Tue, 07 May 2019 17:33:36 GMT
ctubbsii commented on a change in pull request #1148: Quick query
URL: https://github.com/apache/accumulo/pull/1148#discussion_r281743486
 
 

 ##########
 File path: server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java
 ##########
 @@ -221,6 +229,30 @@ long calculateCount() {
     }
   }
 
+  public Query fetchQuery(String tableName, Range range) {
+    if (tableName == null)
+      tableName = "test_ingest";
+    ServerContext context = getContext();
+    Query result = new Query();
+    long count = 0L;
+    log.info("MIKE query value = " + range);
+
+    try {
+      BatchScanner scanner = context.createBatchScanner(tableName, Authorizations.EMPTY);
+      ArrayList<Range> ranges = new ArrayList<>();
+      ranges.add(range);
+      scanner.setRanges(ranges);
+      for (Entry<Key, Value> entry : scanner) {
 
 Review comment:
   The monitor generally runs with a low memory footprint, with the purpose of serving multiple
users. A single large row could kill it, not just full table scans. Avoiding a full table
scan isn't sufficient.
   
   We currently mitigate the amount of load a user can trigger the monitor to perform by limiting
our refresh of the stats in the monitor to no more than once every 5 seconds. But, there's
no way to limit the load a user could initiate when they can initiate arbitrary work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message