accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option
Date Fri, 03 May 2019 14:37:41 GMT
keith-turner commented on a change in pull request #1135: Issue 1129 fix grep pn option
URL: https://github.com/apache/accumulo/pull/1135#discussion_r280799746
 
 

 ##########
 File path: shell/src/main/java/org/apache/accumulo/shell/commands/GrepCommand.java
 ##########
 @@ -71,10 +71,11 @@ public int execute(final String fullCommand, final CommandLine cl, final
Shell s
       scanner.setTimeout(getTimeout(cl), TimeUnit.MILLISECONDS);
 
       setupSampling(tableName, cl, shellState, scanner);
+      addScanIterators(shellState, cl, scanner, "");
 
       for (int i = 0; i < cl.getArgs().length; i++) {
         setUpIterator(Integer.MAX_VALUE - cl.getArgs().length + i, "grep" + i, cl.getArgs()[i],
-            scanner, cl, negate);
+            scanner, cl, negate, shellState);
 
 Review comment:
   `shellState` is newly passed, but it seems like its not used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message