accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo-website] keith-turner commented on a change in pull request #172: Specify branch using -b with ghc tag
Date Wed, 24 Apr 2019 20:39:23 GMT
keith-turner commented on a change in pull request #172: Specify branch using -b with ghc tag
URL: https://github.com/apache/accumulo-website/pull/172#discussion_r278308263
 
 

 ##########
 File path: README.md
 ##########
 @@ -49,7 +49,7 @@ The source for these tags is at [_plugins/links.rb](_plugins/links.rb).
 | dlink | Creates Documentation link | None                                             
                              | `{% dlink getting-stared/clients %}`                   |
 | durl  | Creates Documentation URL  | None                                             
                              | `{% durl troubleshooting/performance %}`                 
 |
 | ghi   | GitHub issue link          | None  | `{% ghi 100 %}` |
-| ghc   | GitHub code link          | None  | `{% ghc server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
%}` |
+| ghc   | GitHub code link          | Branch defaults to `gh_branch` setting in `_config.yml`.
Override using `-b` | `{% ghc server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
%}` `{% ghc -t 1.9 README.md %}` |
 
 Review comment:
   This example shows a `-t` option but I see `-b` in the ruby code diff.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message