accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] keith-turner commented on a change in pull request #1060: Closes #1053 add multi-volume support to import table command.
Date Mon, 15 Apr 2019 23:55:09 GMT
keith-turner commented on a change in pull request #1060: Closes #1053 add multi-volume support
to import table command.
URL: https://github.com/apache/accumulo/pull/1060#discussion_r275585496
 
 

 ##########
 File path: test/src/main/java/org/apache/accumulo/test/ImportExportIT.java
 ##########
 @@ -119,23 +126,25 @@ public void testExportImportThenScan() throws Exception {
       FSDataInputStream is = fs.open(distcp);
       BufferedReader reader = new BufferedReader(new InputStreamReader(is));
 
-      // Copy each file that was exported to the import directory
+      // Copy each file that was exported to one of the imports directory
       String line;
+
       while ((line = reader.readLine()) != null) {
         Path p = new Path(line.substring(5));
         assertTrue("File doesn't exist: " + p, fs.exists(p));
-
+        Path importDir = importDirAry[r.nextInt(importDirAry.length)];
         Path dest = new Path(importDir, p.getName());
         assertFalse("Did not expect " + dest + " to exist", fs.exists(dest));
         FileUtil.copy(fs, p, fs, dest, false, fs.getConf());
       }
 
       reader.close();
 
-      log.info("Import dir: {}", Arrays.toString(fs.listStatus(importDir)));
+      log.info("Import dir A: {}", Arrays.toString(fs.listStatus(importDirA)));
 
 Review comment:
   Does this test create more than one file for export?  When you run this test do you see
files for each dir?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message