accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1067: Log status times to debug log
Date Mon, 01 Apr 2019 16:56:13 GMT
ctubbsii commented on a change in pull request #1067: Log status times to debug log
URL: https://github.com/apache/accumulo/pull/1067#discussion_r270960286
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/Master.java
 ##########
 @@ -1206,13 +1206,20 @@ private long balanceTablets() {
           Thread t = Thread.currentThread();
           String oldName = t.getName();
           try {
-            t.setName("Getting status from " + server);
+            String message = "Getting status from " + server;
+            t.setName(message);
+            long startForServer = System.currentTimeMillis();
+            log.debug(message);
             TServerConnection connection1 = tserverSet.getConnection(server);
             if (connection1 == null) {
               throw new IOException("No connection to " + server);
             }
             TabletServerStatus status = connection1.getTableMap(false);
             result.put(server, status);
+
+            long duration = System.currentTimeMillis() - startForServer;
+            log.debug("Got status from " + server + " in " + duration + " ms");
 
 Review comment:
   Why not trace instead (I mean tracing library, not trace log level)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message