From notifications-return-48411-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Fri Mar 8 22:48:25 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9FED918067E for ; Fri, 8 Mar 2019 23:48:24 +0100 (CET) Received: (qmail 40933 invoked by uid 500); 8 Mar 2019 22:48:23 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 40886 invoked by uid 99); 8 Mar 2019 22:48:23 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Mar 2019 22:48:23 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] [accumulo-testing] milleruntime commented on a change in pull request #64: Made CI bulk import configurable and scriptable Message-ID: <155208530313.5727.18051304917724143506.gitbox@gitbox.apache.org> Date: Fri, 08 Mar 2019 22:48:23 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit milleruntime commented on a change in pull request #64: Made CI bulk import configurable and scriptable URL: https://github.com/apache/accumulo-testing/pull/64#discussion_r263955432 ########## File path: src/main/java/org/apache/accumulo/testing/continuous/BulkIngest.java ########## @@ -103,157 +102,13 @@ public int run(String[] args) throws Exception { job.waitForCompletion(true); boolean success = job.isSuccessful(); - // bulk import completed files - if (success) { - log.info("Sort and create job successful. Bulk importing {} to {}", RFILE_DIR, tableName); - client.tableOperations().importDirectory(RFILE_DIR).to(tableName).load(); - } else { - log.error("Job failed, not calling bulk import"); - } return success ? 0 : 1; Review comment: Looks like you don't need `success` anymore ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services