accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [accumulo] ctubbsii commented on a change in pull request #1027: Fix possible bug and improve errors in Tablet
Date Tue, 12 Mar 2019 22:20:41 GMT
ctubbsii commented on a change in pull request #1027: Fix possible bug and improve errors in
Tablet
URL: https://github.com/apache/accumulo/pull/1027#discussion_r264906526
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -918,13 +921,13 @@ DataFileValue minorCompact(InMemoryMap memTable, FileRef tmpDatafile,
FileRef ne
       return new DataFileValue(stats.getFileSize(), stats.getEntriesWritten());
     } catch (Exception | Error e) {
       failed = true;
-      throw new RuntimeException(e);
+      throw new RuntimeException("Exception occurred during minor compaction on " + extent,
e);
     } finally {
       Thread.currentThread().setName(oldName);
       try {
         getTabletMemory().finalizeMinC();
       } catch (Throwable t) {
-        log.error("Failed to free tablet memory", t);
+        log.error("Failed to free tablet memory on " + extent, t);
 
 Review comment:
   ```suggestion
           log.error("Failed to free tablet memory on {}", extent, t);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message