From notifications-return-47790-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org Fri Feb 8 16:44:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0328918067A for ; Fri, 8 Feb 2019 17:44:46 +0100 (CET) Received: (qmail 85244 invoked by uid 500); 8 Feb 2019 16:44:46 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 85233 invoked by uid 99); 8 Feb 2019 16:44:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Feb 2019 16:44:46 +0000 From: GitBox To: notifications@accumulo.apache.org Subject: [GitHub] ctubbsii commented on a change in pull request #943: Changes to make 2.0 API more backward compatible Message-ID: <154964428555.10317.1580700281991999773.gitbox@gitbox.apache.org> Date: Fri, 08 Feb 2019 16:44:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ctubbsii commented on a change in pull request #943: Changes to make 2.0 API more backward compatible URL: https://github.com/apache/accumulo/pull/943#discussion_r255149552 ########## File path: core/src/main/java/org/apache/accumulo/core/client/ClientConfiguration.java ########## @@ -50,7 +50,7 @@ * @deprecated since 2.0.0, replaced by {@link Accumulo#newClient()} */ @Deprecated -public class ClientConfiguration { +public class ClientConfiguration extends CompositeConfiguration { Review comment: Yes, the type is incompatible with commons-configuration2. However, that problem exists regardless of whether it is in the public API or not. But, having it in the public API prevents us from migrating to commons-configuration2. So, it needs to be out of the public API so we can update it, whether to match what Hadoop is using, for class path convergence, or for security updates. In all such cases, we cannot upgrade it if it remains in the public API. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services