accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #60: Factor RFile and CryptoServiceFactory from Import-Control
Date Wed, 27 Feb 2019 13:15:02 GMT
ctubbsii commented on a change in pull request #60: Factor RFile and CryptoServiceFactory from
Import-Control
URL: https://github.com/apache/accumulo-testing/pull/60#discussion_r260741939
 
 

 ##########
 File path: src/main/java/org/apache/accumulo/testing/ingest/TestIngest.java
 ##########
 @@ -226,11 +227,8 @@ public static void ingest(AccumuloClient client, FileSystem fs, Opts
opts,
     FileSKVWriter writer = null;
 
     if (opts.outputFile != null) {
-      writer = FileOperations
-          .getInstance()
-          .newWriterBuilder()
-          .forFile(opts.outputFile + "." + RFile.EXTENSION, fs, conf,
-              CryptoServiceFactory.newDefaultInstance())
+      writer = FileOperations.getInstance().newWriterBuilder()
 
 Review comment:
   For what it's worth, RFileWriter is AutoCloseable, and could be used inside a try-with-resources
block. Should at least ensure it's closed in a finally block, if not null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message