accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #899: Move encrypted log flush to synch thread. Fixes #839
Date Fri, 22 Feb 2019 19:49:17 GMT
milleruntime commented on a change in pull request #899: Move encrypted log flush to synch
thread. Fixes #839
URL: https://github.com/apache/accumulo/pull/899#discussion_r259487536
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
 ##########
 @@ -558,7 +559,6 @@ public LoggerOperation defineTablet(CommitSession cs) throws IOException
{
   private synchronized void write(LogFileKey key, LogFileValue value) throws IOException
{
     key.write(encryptingLogFile);
     value.write(encryptingLogFile);
-    encryptingLogFile.flush();
 
 Review comment:
   I tested this with Uno and the encryption plugin enabled.  I was able to ingest 3 million
rows and scan through the shell.  So I believe this works with our AES crypto impl.  I guess
if someone discovered an impl that it doesn't work with, we can address it then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message