accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] milleruntime commented on a change in pull request #964: Update trace tooling
Date Fri, 22 Feb 2019 18:48:23 GMT
milleruntime commented on a change in pull request #964: Update trace tooling
URL: https://github.com/apache/accumulo/pull/964#discussion_r259454162
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/util/ChangeSecret.java
 ##########
 @@ -69,19 +70,21 @@ public static void main(String[] args) throws Exception {
     argsList.add("--old");
     argsList.add("--new");
     argsList.addAll(Arrays.asList(args));
-    opts.parseArgs(ChangeSecret.class.getName(), argsList.toArray(new String[0]));
+    try (TraceScope clientSpan = opts.parseArgsAndTrace(ChangeSecret.class.getName(),
 
 Review comment:
   The clientSpan variable is never used. You could take out the try with resources and call
`clientSpan.close();` at the end.  Which is almost the same thing but IDEs and code analysis
tools will at least recognize the use of clientSpan.  IntelliJ gives me this warning FYI.
 I think the only difference is if and error is thrown the span wouldn't get closed though.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message