accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #967: Fixed code quality issues found by lgtm.com
Date Sun, 17 Feb 2019 19:41:25 GMT
ctubbsii commented on a change in pull request #967: Fixed code quality issues found by lgtm.com
URL: https://github.com/apache/accumulo/pull/967#discussion_r257519314
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooLock.java
 ##########
 @@ -399,9 +399,7 @@ public synchronized void process(WatchedEvent event) {
       } catch (Exception ex) {
         if (lock != null || asyncLock != null) {
           lockWatcher.unableToMonitorLockNode(ex);
-          log.error(
-              "Error resetting watch on ZooLock " + lock == null ? asyncLock : lock + " "
+ event,
-              ex);
+          log.error("Error resetting watch on ZooLock " + lock + " " + event, ex);
 
 Review comment:
   This is a different log message than before if lock == null; it never logs the asyncLock
info in that case.
   
   How about:
   ```suggestion
             log.error("Error resetting watch on ZooLock {} {}", lock != null ? lock : asyncLock,
event, ex);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message