accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ctubbsii commented on a change in pull request #943: Changes to make 2.0 API more backward compatible
Date Fri, 08 Feb 2019 17:05:39 GMT
ctubbsii commented on a change in pull request #943: Changes to make 2.0 API more backward
compatible
URL: https://github.com/apache/accumulo/pull/943#discussion_r255157879
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/rfile/RFile.java
 ##########
 @@ -408,7 +408,9 @@ public static SummaryInputArguments summaries() {
      *          Configuration for summarizer to run.
      * @since 2.0.0
      */
-    WriterOptions withSummarizers(SummarizerConfiguration... summarizerConf);
+    default WriterOptions withSummarizers(SummarizerConfiguration... summarizerConf) {
 
 Review comment:
   The default method is definitely a clever solution that helps with strict adherence to
Semver. So, it's probably worth doing for that reason alone. I don't think it would affect
users unless they implemented the interfaces in their own code, which I can't imagine a sane
reason for doing, but people are unpredictable and have done crazier things. :smiley_cat:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message